Skip to content

Conversation

@lukaslihotzki-f
Copy link
Contributor

No description provided.

@lukaslihotzki-f lukaslihotzki-f requested a review from a team as a code owner May 15, 2025 20:24
@codecov
Copy link

codecov bot commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.58%. Comparing base (e685958) to head (8a36f51).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
- Coverage   78.66%   78.58%   -0.08%     
==========================================
  Files         472      472              
  Lines       67655    67540     -115     
  Branches    10419    10415       -4     
==========================================
- Hits        53220    53076     -144     
- Misses      10917    10927      +10     
- Partials     3518     3537      +19     

see 63 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e685958...8a36f51. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jason-famedly
Copy link
Contributor

jason-famedly commented May 16, 2025

@nico-famedly
Copy link
Member

So this is blocked until those above things are released?

@jason-famedly
Copy link
Contributor

Actually, could bump the versions again, there was a release about 4 days ago. @lukaslihotzki-f

@emgrav
Copy link
Member

emgrav commented Jun 11, 2025

We should try to get this merged

@lukaslihotzki-f lukaslihotzki-f force-pushed the ll/bump-opentelemetry branch 2 times, most recently from 525270c to 37d4ba5 Compare June 11, 2025 19:40
@lukaslihotzki-f
Copy link
Contributor Author

I have bumped the opentelemetry version in this PR. Now, the OTLP test passes. The sytest also fails in the master branch, so I think this PR can be merged now.

Copy link
Contributor

@jason-famedly jason-famedly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The tests will continue to fail until we get at least 1.129.0 merged in. Thank you so much for this!

@lukaslihotzki-f lukaslihotzki-f force-pushed the ll/bump-opentelemetry branch from 37d4ba5 to 03a83f7 Compare June 11, 2025 20:54
@lukaslihotzki-f lukaslihotzki-f merged commit 03a83f7 into master Jun 11, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants