-
Notifications
You must be signed in to change notification settings - Fork 4
chore(opentelemetry): use released versions instead of git versions #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #37 +/- ##
==========================================
- Coverage 78.66% 78.58% -0.08%
==========================================
Files 472 472
Lines 67655 67540 -115
Branches 10419 10415 -4
==========================================
- Hits 53220 53076 -144
- Misses 10917 10927 +10
- Partials 3518 3537 +19 see 63 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
From out-of-band chat:
actually, looks like that dev goofed a bit, new PR:
(mostly so I can find them easily again) |
|
So this is blocked until those above things are released? |
|
Actually, could bump the versions again, there was a release about 4 days ago. @lukaslihotzki-f |
|
We should try to get this merged |
525270c to
37d4ba5
Compare
|
I have bumped the opentelemetry version in this PR. Now, the OTLP test passes. The sytest also fails in the master branch, so I think this PR can be merged now. |
jason-famedly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The tests will continue to fail until we get at least 1.129.0 merged in. Thank you so much for this!
37d4ba5 to
03a83f7
Compare
No description provided.