Support EIP-6963: Multi Injected Provider Discovery #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
getting this deployed on vercel is the best way to test on an in-app wallet browser (cant use localhost). using alert because there are no dev tools in these in-app browsers
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EIP-6963: Multi Injected Provider Discovery
The biggest issue that this PR resolves is where multiple wallets try to override the
window.ethereumobject resulting in conflicts with one another.This update to ConnectKit abstracts away all the new EIP-6963 wallet discovery logic into a useful
useWalletsHook for easier future feature development.Preview: https://connectkit-nextjs-git-eip-6963-avaraxyz.vercel.app/
UX Logic:
EIP-6963 enabled wallets are hoisted to the top of the discovery list, whilst legacy implementations using the
window.ethereumobject are left at the bottom to encourage wallets to update to the latest protocol.TODO:
WalletConfigProps&WalletPropstypes.LegacyWalletPropsto continue supporting this protocol until EIP-6963 has been fully adopted.