Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking] Flatten withEffects and aperture APIs #124

Merged
merged 7 commits into from
Nov 26, 2018
Merged

Conversation

troch
Copy link
Collaborator

@troch troch commented Nov 24, 2018

Flatten withEffects and aperture APIs to allow for optional effect handlers.

withEffects(aperture, { hander, errorHandler, Context })

const aperture = (component, initialProps, initialContext) => {}

This is a breaking change, and versions will be bumped to v3.0.0

Advantages

  • More compact syntax
  • Less closures (if that matters)
  • Handler can be optional
  • Easier access to component in Aperture (initialProps and initialContext can be ignored)

TODO

  • Update code
  • Update tests
  • Update docs

Examples will be updated once released.

@troch troch changed the base branch from master to v3 November 24, 2018 20:08
base/react/withEffects.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@thisRaptori thisRaptori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna have to read through the docs in full once we're ready for v3 so we can make sure it's all consistent 😁

base/react/README.tpl.md Outdated Show resolved Hide resolved
base/react/README.tpl.md Outdated Show resolved Hide resolved
docs/api/withEffects.md Outdated Show resolved Hide resolved
docs/api/withEffects.md Show resolved Hide resolved
docs/api/withEffects.md Show resolved Hide resolved
docs/glossary.md Show resolved Hide resolved
Copy link
Collaborator

@thisRaptori thisRaptori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last comments, looks good aside from that!

base/react/observable_callbag.ts Show resolved Hide resolved
base/react/observable_most.ts Show resolved Hide resolved
base/react/observable_xstream.ts Show resolved Hide resolved
@troch troch merged commit 12f3121 into v3 Nov 26, 2018
@thisRaptori thisRaptori deleted the optional-handler branch August 16, 2019 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants