Fix ObservableComponent::useEvent ignoring seed #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ObservableComponent::useEvent checked whether more than one argument was supplied (correct), but used the 3rd argument as a seed value instead. That argument is always undefined when using Refract according to the docs. This bug was introduced with commit d24f0f0. This commit changes the function signature back to the original one of using 2 args, one being optional. The check for the actual argument count is then done using the arguments object.
The arguments object cannot be used in arrow functions. useEvent doesn't have to be an arrow function, so we define it as a regular function instead.
|
Oh wow... Thanks for the fix. Yeah arrow functions don't have Would replacing args[2] with args[1] work? |
|
Had to do a force push to clean up the commit message, sorry about that. Replacing |
No worries, I don't mind force pushing 😂 |
troch
approved these changes
Dec 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ObservableComponent::useEvent checked whether
more than one argument was supplied (correct), but
used the 3rd argument as a seed value instead.
That argument is always undefined when using
Refract according to the docs.
This bug was introduced with commit d24f0f0.
This commit changes the function signature back
to the original one of using 2 args, one being
optional. The check for the actual argument count
is then done using the arguments object.
Fixes #134