Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to react 17 and remove package dependencies of < 17 #190

Merged
merged 2 commits into from
Dec 29, 2021

Conversation

kyorkston
Copy link
Contributor

@kyorkston kyorkston commented Dec 23, 2021

  • Removes package dependencies of React < 17
  • Upgrades React and types packages to 17
  • Addes react-testing-library for testing
  • Unit tests run
  • Build scripts run

@kyorkston kyorkston marked this pull request as ready for review December 23, 2021 09:11
@kyorkston kyorkston added the react Something related to React packages label Dec 23, 2021
@liamjdouglas
Copy link

@troch @thisRaptori do either of you still have access to npm for this for publishing updates? If so are you able to grant access/transfer ownership please

@thisRaptori
Copy link
Collaborator

thisRaptori commented Dec 23, 2021

@liamjdouglas yep! Could you confirm your username on npm? Also make sure you've got 2FA enabled!

Also, if you want to chat about it in real-time, you can ping me on the Reactiflux Discord server - there's a #refract channel, though at some point we might roll it into the #rxjs one. I'm Raptori#1545 on there, feel free to ping me!

@kyorkston
Copy link
Contributor Author

Could you add me @thisRaptori ? It's kyorkston on npm

@thisRaptori
Copy link
Collaborator

Done! @kyorkston

@kyorkston kyorkston merged commit cb5df0e into master Dec 29, 2021
@kyorkston kyorkston deleted the react-17 branch December 29, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
react Something related to React packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot install refract-rxjs because package asserts the react page must be a version between 15.0.0 < 17.0.0
3 participants