-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
* added option to place user/password combinations in flatfile #18
base: master
Are you sure you want to change the base?
Conversation
strima
commented
Apr 23, 2014
- added option to place user/password combinations in flatfile
- added configurable option for base_path (so that you can "mount" the whole proxy under eg /kibanaauthproxy)
* added configurable option for base_path (so that you can "mount" the whole proxy under eg /kibanaauthproxy)
Placing user/password separated is really a good feature, but I will not merge the base_path because it's not so necessary in most common cases. just want to keep it simple. Thanks for your efforts:) |
and if i do something like that: if (!config.base_path) { then it would be ok if this option is not specified, but for others that want/need it it would still be there what do you think ? |
Good that's perfect. BTW, Could you please add the basic_auth_file section and its description into config.js? so that I can merge the features easily. Thanks. |
done as proposed. hope it's ok now. btw, i adopted the whole thing for grafana. see https://github.com/strima/grafana-authentication-proxy hope that's ok - i mentioned this project of course as base |
Never mind, you are welcomed to fork or adopt as you go. it's helpful to the community, thank you :) |
…sers, thus enabling some kind of access authorization
Merge branch 'master' of https://github.com/strima/kibana-authentication-proxy
hi, as written in the config.js and readme.md i added an option for user based regex filtering of elasticsearch indizes, thus enabling some kind of authorization. can be used eg. for restricting certain users to certain logstash indizes - thus not seeing all logs only the ones which are relevant for the user |
@fangli : did you already have time to do your tests ? |
…art is necessary after changes on either of those