Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* added option to place user/password combinations in flatfile #18

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

strima
Copy link

@strima strima commented Apr 23, 2014

  • added option to place user/password combinations in flatfile
  • added configurable option for base_path (so that you can "mount" the whole proxy under eg /kibanaauthproxy)

* added configurable option for base_path (so that you can "mount" the whole proxy under eg /kibanaauthproxy)
@fangli
Copy link
Owner

fangli commented Apr 24, 2014

Placing user/password separated is really a good feature, but I will not merge the base_path because it's not so necessary in most common cases. just want to keep it simple.

Thanks for your efforts:)

@strima
Copy link
Author

strima commented Apr 24, 2014

and if i do something like that:

if (!config.base_path) {
config.base_path="";
}

then it would be ok if this option is not specified, but for others that want/need it it would still be there

what do you think ?

@fangli
Copy link
Owner

fangli commented Apr 25, 2014

Good that's perfect.

BTW, Could you please add the basic_auth_file section and its description into config.js? so that I can merge the features easily.
Default value of basic_auth_file should be ""[empty], and If it's specific, the content in this file will take place of basic_auth_users.

Thanks.

@strima
Copy link
Author

strima commented Apr 28, 2014

done as proposed. hope it's ok now.

btw, i adopted the whole thing for grafana. see https://github.com/strima/grafana-authentication-proxy

hope that's ok - i mentioned this project of course as base

@fangli
Copy link
Owner

fangli commented Apr 30, 2014

Never mind, you are welcomed to fork or adopt as you go. it's helpful to the community, thank you :)
I'll merge the pull request later, after performed a few tests.

@strima
Copy link
Author

strima commented May 13, 2014

hi, as written in the config.js and readme.md i added an option for user based regex filtering of elasticsearch indizes, thus enabling some kind of authorization.

can be used eg. for restricting certain users to certain logstash indizes - thus not seeing all logs only the ones which are relevant for the user

@strima
Copy link
Author

strima commented Aug 5, 2014

@fangli : did you already have time to do your tests ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants