Fix S3 URL

closes pulp#767 Ref: pulp/pulpcore#2684
fao89 · May 9, 2022 · 40e8528 · 40e8528
1 parent e41126c
commit 40e8528
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/CHANGES/767.bugfix b/CHANGES/767.bugfix
@@ -0,0 +1 @@
+Fixed generation of the redirect url to the object storage
diff --git a/pulp_container/app/redirects.py b/pulp_container/app/redirects.py
@@ -110,7 +110,7 @@ def redirect_to_object_storage(self, artifact, return_media_type):
         filename = os.path.basename(artifact.file.name)
         parameters = {
             "ResponseContentType": return_media_type,
-            "ResponseContentDisposition": f"attachment;filename={filename}",
+            "ResponseContentDisposition": f"attachment%3Bfilename={filename}",
         }
         content_url = artifact.file.storage.url(
             artifact.file.name, parameters=parameters, http_method=self.request.method
@@ -130,7 +130,7 @@ def redirect_to_object_storage(self, artifact, return_media_type):
         filename = os.path.basename(artifact.file.name)
         parameters = {
             "content_type": return_media_type,
-            "content_disposition": f"attachment;filename={filename}",
+            "content_disposition": f"attachment%3Bfilename={filename}",
         }
         content_url = artifact.file.storage.url(artifact.file.name, parameters=parameters)
         return redirect(content_url)
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fixed generation of the redirect url to the object storage