Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also remove arch from feature for MacOS #112

Merged
merged 1 commit into from
Jan 21, 2024
Merged

Also remove arch from feature for MacOS #112

merged 1 commit into from
Jan 21, 2024

Conversation

guw
Copy link
Contributor

@guw guw commented Jan 20, 2024

No description provided.

@fappel fappel merged commit cbdd31d into fappel:development Jan 21, 2024
@fappel
Copy link
Owner

fappel commented Jan 21, 2024

Changes are merged and ready for testing on the development repository. Just one question. I noticed that you've removed also the fragment=true flag on the dependency declarations to the fragments. Are those statements superfluous?

@guw
Copy link
Contributor Author

guw commented Jan 21, 2024

Oh that's a good question. I used PDE's feature editor and did not pay attention to this detail.

@guw
Copy link
Contributor Author

guw commented Jan 21, 2024

Confirmed it works now on Apple Silicon:

g! ss codeaffine
"Framework is launched."

id	State       Bundle
2412	ACTIVE      com.codeaffine.eclipse.swt_0.8.0.20240121-0326
2413	ACTIVE      com.codeaffine.eclipse.ui.swt.theme_0.10.0.20240121-0326
	            Fragments=2414
2414	RESOLVED    com.codeaffine.eclipse.ui.swt.theme.mac_0.10.0.20240121-0326
	            Master=2413
2415	STARTING    com.codeaffine.util_0.1.0.20240121-0326

@fappel
Copy link
Owner

fappel commented Jan 24, 2024

Great! Before I actually release the new version I will give it a try on a windows machine. However that will have to wait till next week. Thanks again

@fappel
Copy link
Owner

fappel commented Feb 2, 2024

Windows check was ok and the new version has been released Thanks for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants