fix: network conversions #264
Conversation
| @@ -428,29 +428,42 @@ impl FromStr for Network { | |||
| } | |||
| } | |||
|
|
|||
| impl From<bitcoin::Network> for Network { | |||
There was a problem hiding this comment.
Can we get both directions?
There was a problem hiding this comment.
Yes we actually can. I rework the commits to not erase the work from @LeoNero as much as I can, thus I have to move the impl from the blockchain module into bitcoin. If this bothers you @LeoNero I can remove that part and you do another PR yourself. I should have catch that in your first PR but I didn't, sorry for that.
There was a problem hiding this comment.
Let's merge this to keep the momentum going. Leo's work is accurately preserved here and if there is something bothering him with the PR here, he can always submit a fresh PR to add more docs/test/functionality.
There was a problem hiding this comment.
Hi just saw that. There is no problem removing my implementation for things to work properly or for better code organization.
h4sh3d
force-pushed
the
feature/monero-blockchain-into
branch
from
18c6080
to
a4998c4
Compare
h4sh3d
force-pushed
the
feature/monero-blockchain-into
branch
from
a4998c4
to
c334930
Compare
Fix #248
When reviewing #247 I missed the conversion flow, it should be
blockchain::Network->btc|xmr::Networkand not the inverse. And the issue was not describing the problem correctly, sorry for that.