Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Derive strict encoding for funding transaction #320

Merged
merged 2 commits into from
Dec 28, 2022
Merged

Feat: Derive strict encoding for funding transaction #320

merged 2 commits into from
Dec 28, 2022

Conversation

TheCharlatan
Copy link
Member

@TheCharlatan TheCharlatan commented Dec 28, 2022 •
edited
Loading

Missed this one :((

h4sh3d
h4sh3d approved these changes Dec 28, 2022
View reviewed changes
Copy link
Member

@h4sh3d h4sh3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a changelog line, then we can merge

@TheCharlatan
Copy link
Member Author

Can you add a changelog line, then we can merge

For missing it for the 47th time 🥇

@h4sh3d h4sh3d merged commit fc4027b into farcaster-project:main Dec 28, 2022
h4sh3d pushed a commit to TheCharlatan/farcaster-core that referenced this pull request Jan 2, 2023
@TheCharlatan @h4sh3d
Feat: Derive strict encoding for funding transaction (farcaster-proje…
10331b5 
…ct#320)

* Feat: Derive strict encoding for funding transaction

* Chore: Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h4sh3d h4sh3d h4sh3d approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheCharlatan @h4sh3d