Refactor(KeyManager): Don't persist master secret #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Derive account level keys on initialization. This has the benefit of informationally segregating instantiated key managers. Since the swap index is not mutable, every swap has to instantiate its own key manager. In order to informationally guarantee that each swap can only read and reach keys with its own swap index, derive the keys to the account index on key manager generation.
TheCharlatan
changed the title
h4sh3d
force-pushed
the
keymanagerRefactor
branch
2 times, most recently
from
f428447
to
441b42a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derive account level keys on initialization.
This has the benefit of informationally segregating instantiated key manager.
Since the swap index is not mutable, every swap has to instantiate its own key manager. In order to informationally guarantee that each swap can only read and reach keys with its own swap index, derive the keys to the account index on key manager generation.
This is the last piece of the puzzle of the swap/wallet refactor that I discussed with @Lederstrumpf .