chore: update deployment parameters #367
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Update the deployment script and tests with realistic deployment parameters.
Change Summary
Update post-deployment setup to transfer ownership and roles to the right destination addresses. Update deployment tests to use
alpha
,beta
,relayer
, andvault
addresses, rather than one test address per parameter. Set storage unit supply to 200k.Merge Checklist
Choose all relevant options below by adding an
x
now or at any time before submitting for reviewAdditional Context
If this is a relatively large or complex change, provide more details here that will help reviewers.
PR-Codex overview
Focus of this PR:
Update the deployment logic and parameters in the
Deploy
contract.Detailed summary:
foundry.toml
file.METADATA_VALIDATOR_OWNER_ADDRESS
in the.env.example
file.deploy
function in theImmutableCreate2Deployer.sol
file to accept a boolean parameterbroadcast
.deploy
function in theImmutableCreate2Deployer.sol
file that calls the previousdeploy
function withbroadcast
set totrue
.deploy
function in theImmutableCreate2Deployer.sol
file to accept a string parametername
and a boolean parameterbroadcast
.deploy
function in theImmutableCreate2Deployer.sol
file that calls the previousdeploy
function withbroadcast
set totrue
.runDeploy
function in theDeploy
contract to accept a boolean parameterbroadcast
.runDeploy
function in theDeploy
contract that calls the previousrunDeploy
function withbroadcast
set totrue
.runDeploy
function in theDeploy
contract that accepts aDeploymentParams
parameter and a boolean parameterbroadcast
.runSetup
function in theDeploy
contract to accept aContracts
parameter and aDeploymentParams
parameter.runSetup
function in theDeploy
contract that calls the previousrunSetup
function withbroadcast
set totrue
.runSetup
function in theDeploy
contract that accepts aContracts
parameter and calls the previousrunSetup
function withbroadcast
set totrue
.runSetup
function in theDeployTest
contract to accept aContracts
parameter and aDeploymentParams
parameter.runSetup
function in theDeployTest
contract that calls the previousrunSetup
function withbroadcast
set totrue
.runSetup
function in theDeployTest
contract that accepts aContracts
parameter and calls the previousrunSetup
function withbroadcast
set totrue
.test_e2e
function in theDeployTest
contract to use thealpha
address instead of theowner
address.test_e2e
function in theDeployTest
contract to call theacceptOwnership
function foridRegistry
andkeyRegistry
.test_e2e
function in theDeployTest
contract to use therelayer
address instead of thebundlerTrustedCaller
address.