Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update deployment parameters #367

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

horsefacts
Copy link
Collaborator

@horsefacts horsefacts commented Aug 22, 2023

Motivation

Update the deployment script and tests with realistic deployment parameters.

Change Summary

Update post-deployment setup to transfer ownership and roles to the right destination addresses. Update deployment tests to use alpha, beta, relayer, and vault addresses, rather than one test address per parameter. Set storage unit supply to 200k.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

Additional Context

If this is a relatively large or complex change, provide more details here that will help reviewers.


PR-Codex overview

Focus of this PR:

Update the deployment logic and parameters in the Deploy contract.

Detailed summary:

  • Decreased the number of fuzz runs in the CI profile in the foundry.toml file.
  • Added a new parameter METADATA_VALIDATOR_OWNER_ADDRESS in the .env.example file.
  • Modified the deploy function in the ImmutableCreate2Deployer.sol file to accept a boolean parameter broadcast.
  • Added a new deploy function in the ImmutableCreate2Deployer.sol file that calls the previous deploy function with broadcast set to true.
  • Modified the deploy function in the ImmutableCreate2Deployer.sol file to accept a string parameter name and a boolean parameter broadcast.
  • Added a new deploy function in the ImmutableCreate2Deployer.sol file that calls the previous deploy function with broadcast set to true.
  • Modified the runDeploy function in the Deploy contract to accept a boolean parameter broadcast.
  • Added a new runDeploy function in the Deploy contract that calls the previous runDeploy function with broadcast set to true.
  • Added a new runDeploy function in the Deploy contract that accepts a DeploymentParams parameter and a boolean parameter broadcast.
  • Modified the runSetup function in the Deploy contract to accept a Contracts parameter and a DeploymentParams parameter.
  • Added a new runSetup function in the Deploy contract that calls the previous runSetup function with broadcast set to true.
  • Added a new runSetup function in the Deploy contract that accepts a Contracts parameter and calls the previous runSetup function with broadcast set to true.
  • Modified the runSetup function in the DeployTest contract to accept a Contracts parameter and a DeploymentParams parameter.
  • Added a new runSetup function in the DeployTest contract that calls the previous runSetup function with broadcast set to true.
  • Added a new runSetup function in the DeployTest contract that accepts a Contracts parameter and calls the previous runSetup function with broadcast set to true.
  • Modified the test_e2e function in the DeployTest contract to use the alpha address instead of the owner address.
  • Modified the test_e2e function in the DeployTest contract to call the acceptOwnership function for idRegistry and keyRegistry.
  • Modified the test_e2e function in the DeployTest contract to use the relayer address instead of the bundlerTrustedCaller address.

The following files were skipped due to too many changes: test/Deploy/Deploy.t.sol

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@horsefacts horsefacts added the chore A task that is none of the other types label Aug 22, 2023
@horsefacts horsefacts merged commit 571a3af into main Aug 22, 2023
3 of 4 checks passed
@horsefacts horsefacts deleted the horsefacts/update-deployment-scripts branch August 22, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A task that is none of the other types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant