Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: L1 deploy script #369

Merged
merged 3 commits into from
Aug 23, 2023
Merged

chore: L1 deploy script #369

merged 3 commits into from
Aug 23, 2023

Conversation

horsefacts
Copy link
Collaborator

@horsefacts horsefacts commented Aug 22, 2023

Motivation

Add an L1 deploy script to deploy the FnameResolver on Ethereum mainnet.

Change Summary

Split deploy scripts into DeployL2 and DeployL1 scripts. Add separate L1_MAINNET_RPC_URL and L2_MAINNET_RPC_URL environment variables. Remove TESTNET_RPC_URL (it's unused).

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR focuses on updating the RPC endpoints and deployment scripts.

Detailed summary

  • Updated RPC endpoints in foundry.toml and .env.example
  • Updated RPC endpoints in .github/workflows/ci.yml
  • Updated RPC endpoints in docker-compose.yml
  • Updated function modifier in FnameResolverTestSuite.sol
  • Updated function visibility in FnameResolver.sol
  • Renamed Deploy contract to DeployL2 in script/Deploy.s.sol
  • Renamed DeployTest contract to DeployL2Test in test/Deploy/Deploy.t.sol
  • Added new DeployL1 contract in script/DeployL1.s.sol
  • Added new DeployL1Test contract in test/Deploy/DeployL1.t.sol

The following files were skipped due to too many changes: test/Deploy/Deploy.t.sol

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@horsefacts horsefacts marked this pull request as ready for review August 22, 2023 23:03
@horsefacts horsefacts added the chore A task that is none of the other types label Aug 22, 2023
@horsefacts horsefacts changed the title L1 deploy script chore: L1 deploy script Aug 22, 2023
@github-actions
Copy link

Coverage after merging horsefacts/l1-deploy-script into main will be

98.99%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Bundler.sol100%100%100%100%
   FnameResolver.sol100%100%100%100%
   IdRegistry.sol100%100%100%100%
   KeyRegistry.sol100%100%100%100%
   StorageRegistry.sol100%100%100%100%
src/lib
   Signatures.sol100%100%100%100%
   TransferHelper.sol0%0%0%0%12, 17, 20, 20, 20
   TrustedCaller.sol100%100%100%100%
src/validators
   SignedKeyRequestValidator.sol100%100%100%100%

@horsefacts horsefacts merged commit 7d9f01b into main Aug 23, 2023
2 checks passed
@horsefacts horsefacts deleted the horsefacts/l1-deploy-script branch August 23, 2023 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A task that is none of the other types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant