test: simplify symbolic tests using new halmos cheatcode #430
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[this is a temporary pr to be upstreamed after halmos v2 is released.]
this pr improves symbolic tests using new halmos cheatcode
createCalldata()
.previously, symbolic tests required custom calldata generators to handle dynamic size arrays and bytes. the new
createCalldata()
cheatcode now seamlessly supports such dynamically-sized parameters by considering all combinations of size candidates. these can be specified using additional flags--array-lengths
and--default-bytes-lengths
(seehalmos -h
for more details.)with this new cheatcode, the symbolic tests are now much simpler to understand and maintain, while also accounting for more combinations of dynamic parameter sizes.
PR-Codex overview
The focus of this PR is to refactor the
check_Invariants_PostMigration
function and remove unnecessary code inIdRegistrySymTest
.Detailed summary
check_Invariants_PostMigration
function inIdRegistrySymTest
_calldataFor
function fromIdRegistrySymTest
check_Invariants
function inKeyRegistrySymTest
to usesvm.createCalldata
split_cases
andmk_calldata
functions fromKeyRegistrySymTest
slice
function toKeyRegistrySymTest