docs: improve chron-feed example, upgrade @Farcaster packages in exam…

…ples (#1126) * docs: fix chronfeed example * bump farcaster package versions in examples * run linter
farcasterxyz · Jul 13, 2023 · 1fd9b2b · 1fd9b2b
1 parent a0dbfbd
commit 1fd9b2b
Show file tree

Hide file tree

Showing 12 changed files with 435 additions and 1,283 deletions.
diff --git a/packages/hub-nodejs/examples/chron-feed/index.ts b/packages/hub-nodejs/examples/chron-feed/index.ts
@@ -41,13 +41,18 @@ const getPrimaryCastsByFid = async (fid: number, client: HubRpcClient): HubAsync
 
 const getFnameFromFid = async (fid: number, client: HubRpcClient): HubAsyncResult<string> => {
   const result = await client.getUserData({ fid: fid, userDataType: UserDataType.USERNAME });
-  return result.map((message) => {
-    if (isUserDataAddMessage(message)) {
-      return message.data.userDataBody.value;
-    } else {
-      return "";
-    }
-  });
+  return ok(
+    result.match(
+      (message) => {
+        if (isUserDataAddMessage(message)) {
+          return message.data.userDataBody.value;
+        } else {
+          return "";
+        }
+      },
+      () => `${fid}!`, // fallback to FID if no username is set
+    ),
+  );
 };
 
 /**
@@ -67,7 +72,7 @@ const compareCasts = (a: CastAddMessage, b: CastAddMessage) => {
  * Converts a CastAddMessage into a printable string representation.
  */
 const castToString = async (cast: CastAddMessage, nameMapping: Map<number, string>, client: HubRpcClient) => {
-  const fname = nameMapping.get(cast.data.fid);
+  const fname = nameMapping.get(cast.data.fid) ?? `${cast.data.fid}!`; // if the user doesn't have a username set, use their FID
 
   // Convert the timestamp to a human readable string
   // Safety: OK to do this since we know the timestamp coming from the Hub must be in the valid range
@@ -104,13 +109,7 @@ const castToString = async (cast: CastAddMessage, nameMapping: Map<number, strin
   const fidToFname = new Map<number, string>();
 
   const fnameResultPromises = FIDS.map((fid) => client.getUserData({ fid, userDataType: UserDataType.USERNAME }));
-  const fnameResults = Result.combine(await Promise.all(fnameResultPromises));
-
-  if (fnameResults.isErr()) {
-    console.error("Fetching fnames failed");
-    console.error(fnameResults.error);
-    return;
-  }
+  const fnameResults = await Promise.all(fnameResultPromises);
 
   fnameResults.map((result) =>
     result.map((uData) => {

diff --git a/packages/hub-nodejs/examples/chron-feed/package.json b/packages/hub-nodejs/examples/chron-feed/package.json
@@ -5,10 +5,11 @@
   "version": "0.0.0",
   "main": "index.ts",
   "scripts": {
-    "start": "tsx index.ts"
+    "start": "tsx index.ts",
+    "typecheck": "yarn tsc --noEmit"
   },
   "dependencies": {
-    "@farcaster/hub-nodejs": "^0.7.0",
+    "@farcaster/hub-nodejs": "^0.8.4",
     "javascript-time-ago": "^2.5.9"
   },
   "devDependencies": {

diff --git a/packages/hub-nodejs/examples/chron-feed/yarn.lock b/packages/hub-nodejs/examples/chron-feed/yarn.lock
diff --git a/packages/hub-nodejs/examples/make-cast/package.json b/packages/hub-nodejs/examples/make-cast/package.json
@@ -5,10 +5,11 @@
   "version": "0.0.0",
   "main": "index.ts",
   "scripts": {
-    "start": "tsx index.ts"
+    "start": "tsx index.ts",
+    "typecheck": "yarn tsc --noEmit"
   },
   "dependencies": {
-    "@farcaster/hub-nodejs": "^0.7.0"
+    "@farcaster/hub-nodejs": "^0.8.4"
   },
   "devDependencies": {
     "tsx": "^3.12.5",