Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Throw error if unable to fetch fname server signature #1120

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

sanjayprabhu
Copy link
Contributor

@sanjayprabhu sanjayprabhu commented Jul 13, 2023

Motivation

We're seeing some logs around failing to verify fname server signatures, add logging to track it down.

Change Summary

Describe the changes being made in 1-2 concise sentences.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

Additional Context

If this is a relatively large or complex change, provide more details here that will help reviewers


PR-Codex overview

Detailed summary

  • Fixed a bug where an error was not being thrown if the server address could not be fetched.
  • Added a check to throw an error if the signer address is invalid.
  • Added a shouldStop flag to stop the provider.
  • Added logging and error handling for failed username proof verification.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@sanjayprabhu sanjayprabhu added the t-bug A fix for a bug with the current system label Jul 13, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jul 13, 2023

🦋 Changeset detected

Latest commit: 5bd10a5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@farcaster/hubble Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.07 🎉

Comparison is base (1fd9b2b) 70.34% compared to head (e462f16) 70.42%.

❗ Current head e462f16 differs from pull request most recent head 5bd10a5. Consider uploading reports for the commit 5bd10a5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1120      +/-   ##
==========================================
+ Coverage   70.34%   70.42%   +0.07%     
==========================================
  Files          79       79              
  Lines        7014     7015       +1     
  Branches     1480     1479       -1     
==========================================
+ Hits         4934     4940       +6     
+ Misses       1949     1944       -5     
  Partials      131      131              
Impacted Files Coverage Δ
apps/hubble/src/eth/fnameRegistryEventsProvider.ts 77.90% <100.00%> (+1.95%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sanjayprabhu sanjayprabhu force-pushed the fix_server_sig_failure branch from e462f16 to 5bd10a5 Compare July 14, 2023 00:22
@sanjayprabhu sanjayprabhu merged commit 3dfc29d into farcasterxyz:main Jul 14, 2023
@sanjayprabhu sanjayprabhu deleted the fix_server_sig_failure branch July 14, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-bug A fix for a bug with the current system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants