fix: fix testnet defaulting to no allowed peers #1151
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The default allowed peer list was empty, this means no peers are allowed. Change it to undefined to allow all peers by default.
Change Summary
Describe the changes being made in 1-2 concise sentences.
Merge Checklist
Choose all relevant options below by adding an
x
now or at any time before submitting for reviewAdditional Context
If this is a relatively large or complex change, provide more details here that will help reviewers
PR-Codex overview
Detailed summary
allowedPeerIds
property fromstring[]
tostring[] | undefined
.allowedPeerIds
property and assigned the value ofoptions.allowedPeers
directly.This PR focuses on modifying the
allowedPeerIds
property in theHub
class. It changes the type ofallowedPeerIds
fromstring[]
tostring[] | undefined
and modifies the assignment of its value from an empty array to the value ofoptions.allowedPeers
.