Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix testnet defaulting to no allowed peers #1151

Merged

Conversation

sanjayprabhu
Copy link
Contributor

@sanjayprabhu sanjayprabhu commented Jul 16, 2023

Motivation

The default allowed peer list was empty, this means no peers are allowed. Change it to undefined to allow all peers by default.

Change Summary

Describe the changes being made in 1-2 concise sentences.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

Additional Context

If this is a relatively large or complex change, provide more details here that will help reviewers


PR-Codex overview

Detailed summary

  • Changed the type of allowedPeerIds property from string[] to string[] | undefined.
  • Removed the assignment of an empty array to allowedPeerIds property and assigned the value of options.allowedPeers directly.

This PR focuses on modifying the allowedPeerIds property in the Hub class. It changes the type of allowedPeerIds from string[] to string[] | undefined and modifies the assignment of its value from an empty array to the value of options.allowedPeers.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@sanjayprabhu sanjayprabhu added the t-bug A fix for a bug with the current system label Jul 16, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jul 16, 2023

⚠️ No Changeset found

Latest commit: 4649983

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jul 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2023 4:03pm

@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (4d28208) 70.56% compared to head (4649983) 70.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1151      +/-   ##
==========================================
- Coverage   70.56%   70.56%   -0.01%     
==========================================
  Files          79       79              
  Lines        7081     7080       -1     
  Branches     1503     1502       -1     
==========================================
- Hits         4997     4996       -1     
  Misses       1953     1953              
  Partials      131      131              
Impacted Files Coverage Δ
apps/hubble/src/hubble.ts 1.37% <0.00%> (+<0.01%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sanjayprabhu sanjayprabhu merged commit 1d9c34a into farcasterxyz:main Jul 16, 2023
@sanjayprabhu sanjayprabhu deleted the fix_testnet_allowed_peers branch July 16, 2023 16:06
@varunsrin varunsrin linked an issue Jul 16, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-bug A fix for a bug with the current system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: unable to connect to testnet
1 participant