Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: revoke signers 1hr after custody event #1177

Merged
merged 2 commits into from
Jul 21, 2023

Conversation

sanjayprabhu
Copy link
Contributor

@sanjayprabhu sanjayprabhu commented Jul 21, 2023

Motivation

To allow us to test the fid recovery flow. Revoking signers immediately will cascade delete all messages immediately.

Change Summary

Describe the changes being made in 1-2 concise sentences.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

Additional Context

If this is a relatively large or complex change, provide more details here that will help reviewers


PR-Codex overview

Detailed summary

  • Added a new feature to revoke signers 1 hour after a custody event
  • Modified the enqueueJob function in index.ts to include a timestamp for the revoke job
  • Added new imports and modified the processJobs function in index.test.ts to manually trigger the revoke job
  • Added a new private function _processJobs in revokeMessagesBySignerJob.ts to process revoke jobs
  • Modified the start and stop functions in revokeMessagesBySignerJob.ts to use the new _processJobs function
  • Modified the processJobs function in revokeMessagesBySignerJob.ts to accept a timestamp parameter for tests
  • Modified the enqueueJob function in revokeMessagesBySignerJobQueue.ts to include a delay for testing purposes

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@sanjayprabhu sanjayprabhu added the t-feat Add a new feature or protocol improvement label Jul 21, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2023

🦋 Changeset detected

Latest commit: 85c45a1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@farcaster/hubble Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2023 10:35pm

@sanjayprabhu sanjayprabhu merged commit c7ec4ca into farcasterxyz:main Jul 21, 2023
@sanjayprabhu sanjayprabhu deleted the revoke_delay branch July 21, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-feat Add a new feature or protocol improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant