Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
subscribe()
RPC is a long-lived one, which causes excessive resource consumption for every open connection. Limit these to 4 per IP and 4096 total per Node.Change Summary
Merge Checklist
Choose all relevant options below by adding an
x
now or at any time before submitting for reviewPR-Codex overview
This PR focuses on limiting the number of simultaneous subscribe() streams by IP address in the Hubble app.
Detailed summary
extractIPAddress
function to extract the IP part from "ip:port"checkNodeAddrs
function to check the IP address to bind to and the combined IP, transport, and port multiaddrSUBSCRIBE_PERIP_LIMIT
andSUBSCRIBE_GLOBAL_LIMIT
constants inserver.ts
IpConnectionLimiter
class to limit the number of simultaneous connections by IP addressServer
class to useIpConnectionLimiter
for rate limiting insubscribe
methodclearRateLimiters
method inServer
class to clear rate limiterseventService.test.ts
andserver.ts