Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Storage RPC #1211

Merged

Conversation

sanjayprabhu
Copy link
Contributor

@sanjayprabhu sanjayprabhu commented Aug 3, 2023

Motivation

Add an RPC to query how many mesages of each type a user can store.

Change Summary

Describe the changes being made in 1-2 concise sentences.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

Additional Context

If this is a relatively large or complex change, provide more details here that will help reviewers


PR-Codex overview

This PR focuses on adding a new RPC method to retrieve current storage limits by FID.

Detailed summary

  • Added GetCurrentStorageLimitsByFid RPC method
  • Updated protobuf files and generated code
  • Updated unit tests
  • Updated documentation

The following files were skipped due to too many changes: apps/hubble/www/docs/docs/api.md, apps/hubble/src/storage/engine/index.test.ts, apps/hubble/src/storage/engine/index.ts, apps/hubble/src/rpc/test/bulkService.test.ts, protobufs/docs/rpc.md, packages/hub-web/src/generated/rpc.ts, apps/hubble/src/storage/stores/onchainEventStore.test.ts, packages/hub-web/src/generated/request_response.ts, packages/hub-nodejs/src/generated/request_response.ts, packages/core/src/protobufs/generated/request_response.ts, apps/hubble/src/rpc/test/server.test.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Aug 3, 2023

🦋 Changeset detected

Latest commit: adb22b5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@farcaster/hub-nodejs Minor
@farcaster/hub-web Minor
@farcaster/core Minor
@farcaster/hubble Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 4, 2023 0:05am

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch coverage: 85.71% and project coverage change: +0.12% 🎉

Comparison is base (67e9466) 69.79% compared to head (adb22b5) 69.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1211      +/-   ##
==========================================
+ Coverage   69.79%   69.91%   +0.12%     
==========================================
  Files          84       84              
  Lines        7574     7591      +17     
  Branches     1648     1650       +2     
==========================================
+ Hits         5286     5307      +21     
+ Misses       2138     2134       -4     
  Partials      150      150              
Files Changed Coverage Δ
packages/core/src/factories.ts 97.30% <ø> (ø)
apps/hubble/src/rpc/server.ts 77.35% <75.00%> (-0.03%) ⬇️
apps/hubble/src/storage/engine/index.ts 83.33% <75.00%> (+0.58%) ⬆️
apps/hubble/src/storage/stores/castStore.ts 95.40% <100.00%> (+0.05%) ⬆️
apps/hubble/src/storage/stores/linkStore.ts 91.00% <100.00%> (ø)
apps/hubble/src/storage/stores/reactionStore.ts 93.45% <100.00%> (ø)
apps/hubble/src/storage/stores/signerStore.ts 98.55% <100.00%> (ø)
apps/hubble/src/storage/stores/userDataStore.ts 85.71% <100.00%> (ø)
...pps/hubble/src/storage/stores/verificationStore.ts 97.14% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanjayprabhu sanjayprabhu changed the title [WIP] feat: Storage RPC feat: Storage RPC Aug 3, 2023
@sanjayprabhu sanjayprabhu added the t-feat Add a new feature or protocol improvement label Aug 3, 2023
@sanjayprabhu sanjayprabhu merged commit 86149d3 into farcasterxyz:main Aug 4, 2023
@sanjayprabhu sanjayprabhu deleted the cassie-heart/storage-rpc branch August 4, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-feat Add a new feature or protocol improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants