-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: last block bugs with events providers #1243
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 1497111 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
5e07706
to
1497111
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1243 +/- ##
==========================================
+ Coverage 70.03% 70.96% +0.93%
==========================================
Files 88 87 -1
Lines 7859 7774 -85
Branches 1704 1687 -17
==========================================
+ Hits 5504 5517 +13
+ Misses 2204 2119 -85
+ Partials 151 138 -13
☔ View full report in Codecov by Sentry. |
Motivation
Describe why this issue should be fixed and link to any relevant design docs, issues or other relevant items.
Change Summary
Describe the changes being made in 1-2 concise sentences.
Merge Checklist
Choose all relevant options below by adding an
x
now or at any time before submitting for reviewAdditional Context
If this is a relatively large or complex change, provide more details here that will help reviewers
PR-Codex overview
This PR focuses on adding support for tracking the last L2 block in the hub state.
Detailed summary
lastL2Block
field to theHubState
protobuf message.L2EventsProvider
to uselastL2Block
fromHubState
for syncing L2 events.L2EventsProvider
to updatelastL2Block
inHubState
after syncing historical events.hub.putHubState()
infnameRegistryEventsProvider.test.ts
to includelastL2Block
.l2EventsProvider.ts
to use new L2 contract addresses and chain ID.Hub
class to removeUpdateNameRegistryEventExpiryJobQueue
and related code.