Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: last block bugs with events providers #1243

Merged
merged 5 commits into from
Aug 14, 2023
Merged

Conversation

sanjayprabhu
Copy link
Contributor

@sanjayprabhu sanjayprabhu commented Aug 9, 2023

Motivation

Describe why this issue should be fixed and link to any relevant design docs, issues or other relevant items.

Change Summary

Describe the changes being made in 1-2 concise sentences.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

Additional Context

If this is a relatively large or complex change, provide more details here that will help reviewers


PR-Codex overview

This PR focuses on adding support for tracking the last L2 block in the hub state.

Detailed summary

  • Added lastL2Block field to the HubState protobuf message.
  • Modified L2EventsProvider to use lastL2Block from HubState for syncing L2 events.
  • Modified L2EventsProvider to update lastL2Block in HubState after syncing historical events.
  • Updated hub.putHubState() in fnameRegistryEventsProvider.test.ts to include lastL2Block.
  • Updated l2EventsProvider.ts to use new L2 contract addresses and chain ID.
  • Updated Hub class to remove UpdateNameRegistryEventExpiryJobQueue and related code.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Aug 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2023 8:23pm

@changeset-bot
Copy link

changeset-bot bot commented Aug 9, 2023

🦋 Changeset detected

Latest commit: 1497111

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@farcaster/hub-web Patch
@farcaster/core Patch
@farcaster/hubble Patch
@farcaster/hub-nodejs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel vercel bot requested a deployment to Preview August 9, 2023 20:47 Abandoned
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage: 69.23% and project coverage change: +0.93% 🎉

Comparison is base (3e601f8) 70.03% compared to head (1497111) 70.96%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1243      +/-   ##
==========================================
+ Coverage   70.03%   70.96%   +0.93%     
==========================================
  Files          88       87       -1     
  Lines        7859     7774      -85     
  Branches     1704     1687      -17     
==========================================
+ Hits         5504     5517      +13     
+ Misses       2204     2119      -85     
+ Partials      151      138      -13     
Files Changed Coverage Δ
apps/hubble/src/hubble.ts 1.23% <ø> (+0.03%) ⬆️
apps/hubble/src/network/utils/networkConfig.ts 40.74% <66.66%> (ø)
apps/hubble/src/eth/l2EventsProvider.ts 75.48% <70.00%> (-0.50%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanjayprabhu sanjayprabhu merged commit 1fcfd49 into main Aug 14, 2023
@sanjayprabhu sanjayprabhu deleted the fix_l2_last_synced branch August 14, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant