Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix a bug where hubs would report status incorrectly. #1245

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

adityapk00
Copy link
Contributor

@adityapk00 adityapk00 commented Aug 10, 2023

Change Summary

  • Add peer check before saying not syncing

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR focuses on fixing the handling of sync status reporting in the Hubble app.

Detailed summary

  • Added a condition to check if the sync engine is not started and there are no peers before logging a message about sync status.
  • Updated the log messages for sync status when there are no peers.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Aug 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2023 5:09pm

@changeset-bot
Copy link

changeset-bot bot commented Aug 10, 2023

🦋 Changeset detected

Latest commit: a13b201

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@farcaster/hubble Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (5e96e13) 69.88% compared to head (a13b201) 69.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1245      +/-   ##
==========================================
- Coverage   69.88%   69.86%   -0.02%     
==========================================
  Files          85       85              
  Lines        7743     7743              
  Branches     1687     1687              
==========================================
- Hits         5411     5410       -1     
- Misses       2177     2178       +1     
  Partials      155      155              

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adityapk00 adityapk00 merged commit 6bb1b43 into farcasterxyz:main Aug 10, 2023
@adityapk00 adityapk00 deleted the syncstatus2 branch August 10, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant