fix: Fetch ipv4 first for public IP #1366
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Fix ipv4 address (over ipv6) if
announce-ip
is not providedMerge Checklist
Choose all relevant options below by adding an
x
now or at any time before submitting for reviewPR-Codex overview
This PR focuses on simplifying IP address fetching in the
getPublicIp
function by using theaxios
library instead of thehttp
module.Detailed summary
http
module withaxios
for making HTTP requests.getPublicIp
function to useaxios
to fetch the public IP address.lastIpFetch
variable and its usage.getPublicIp
function.