Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fetch ipv4 first for public IP #1366

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

adityapk00
Copy link
Contributor

@adityapk00 adityapk00 commented Sep 8, 2023

Change Summary

Fix ipv4 address (over ipv6) if announce-ip is not provided

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR focuses on simplifying IP address fetching in the getPublicIp function by using the axios library instead of the http module.

Detailed summary

  • Replaced the http module with axios for making HTTP requests.
  • Updated the getPublicIp function to use axios to fetch the public IP address.
  • Removed the lastIpFetch variable and its usage.
  • Updated error handling in the getPublicIp function.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Sep 8, 2023

🦋 Changeset detected

Latest commit: c224278

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@farcaster/hubble Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 8, 2023 4:43pm

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch has no changes to coverable lines.

Files Changed Coverage
apps/hubble/src/utils/p2p.ts 0.00%

📢 Thoughts on this report? Let us know!.

@adityapk00 adityapk00 merged commit 7daaae4 into farcasterxyz:main Sep 8, 2023
@adityapk00 adityapk00 deleted the fixipaddr branch September 8, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant