Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Grafana sync times are blank for longer time ranges #1385

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

adityapk00
Copy link
Contributor

@adityapk00 adityapk00 commented Sep 13, 2023

Change Summary

  • Fix grafana formula

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR focuses on fixing an issue in Grafana where sync times are blank for longer timeranges.

Detailed summary:

  • Changed lineInterpolation from "stepBefore" to "smooth"
  • Changed target value from "stats.timers.hubble.syncengine.sync_time_ms.mean" to "stats.timers.hubble.syncengine.sync_time_ms.sum"

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Sep 13, 2023

🦋 Changeset detected

Latest commit: b125903

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@farcaster/hubble Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2023 5:42pm

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

@adityapk00 adityapk00 merged commit 82c996a into farcasterxyz:main Sep 13, 2023
@adityapk00 adityapk00 deleted the grafup branch September 13, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant