Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add text input frame field #1639

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

sanjayprabhu
Copy link
Contributor

@sanjayprabhu sanjayprabhu commented Feb 1, 2024

Motivation

Add text input frame field

Change Summary

Describe the changes being made in 1-2 concise sentences.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

Additional Context

If this is a relatively large or complex change, provide more details here that will help reviewers


PR-Codex overview

This PR adds a text input field to the frame action body in order to capture user input.

Detailed summary

  • Added inputText field to the FrameActionBody protobuf message
  • Updated validation logic in validations.ts to validate the inputText field
  • Updated generated code in message.ts and generated/message.ts to include the inputText field

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@sanjayprabhu sanjayprabhu added the t-feat Add a new feature or protocol improvement label Feb 1, 2024
Copy link

changeset-bot bot commented Feb 1, 2024

🦋 Changeset detected

Latest commit: 4c9d2b3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@farcaster/hub-nodejs Patch
@farcaster/hub-web Patch
@farcaster/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2024 11:49pm

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fd9f9ff) 73.77% compared to head (4c9d2b3) 73.86%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1639      +/-   ##
==========================================
+ Coverage   73.77%   73.86%   +0.09%     
==========================================
  Files          99       99              
  Lines        9002     9007       +5     
  Branches     1999     2001       +2     
==========================================
+ Hits         6641     6653      +12     
+ Misses       2243     2236       -7     
  Partials      118      118              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanjayprabhu sanjayprabhu merged commit 362f580 into farcasterxyz:main Feb 2, 2024
10 checks passed
@sanjayprabhu sanjayprabhu deleted the new_frame_fields branch February 2, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-feat Add a new feature or protocol improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant