-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add more metrics to hub stream reader #2302
chore: add more metrics to hub stream reader #2302
Conversation
🦋 Changeset detectedLatest commit: af649f3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2302 +/- ##
===========================================
- Coverage 74.05% 44.32% -29.74%
===========================================
Files 99 146 +47
Lines 9425 25496 +16071
Branches 2097 9113 +7016
===========================================
+ Hits 6980 11300 +4320
- Misses 2327 12437 +10110
- Partials 118 1759 +1641 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a changeset
06eb978
to
af649f3
Compare
We need some more instrumentation to understand how much of a time to read delay is accounted for by the hub stream -> redis step vs the redis -> postgres step.
Merge Checklist
Choose all relevant options below by adding an
x
now or at any time before submitting for reviewPR-Codex overview
This PR adds more metrics to
HubSubscriber
.Detailed summary
shardKey
property toEventStreamHubSubscriber