Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add more metrics to hub stream reader #2302

Conversation

aditiharini
Copy link
Contributor

@aditiharini aditiharini commented Sep 10, 2024

We need some more instrumentation to understand how much of a time to read delay is accounted for by the hub stream -> redis step vs the redis -> postgres step.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR adds more metrics to HubSubscriber.

Detailed summary

  • Added shardKey property to EventStreamHubSubscriber
  • Added metrics for batch size and process time per event and per batch

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Sep 10, 2024

🦋 Changeset detected

Latest commit: af649f3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@farcaster/shuttle Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 10:04pm

@aditiharini aditiharini added the t-chore Miscellaneous improvements label Sep 10, 2024
@aditiharini aditiharini marked this pull request as ready for review September 10, 2024 19:44
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 44.32%. Comparing base (1880070) to head (af649f3).
Report is 343 commits behind head on main.

Files with missing lines Patch % Lines
packages/shuttle/src/shuttle/hubSubscriber.ts 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2302       +/-   ##
===========================================
- Coverage   74.05%   44.32%   -29.74%     
===========================================
  Files          99      146       +47     
  Lines        9425    25496    +16071     
  Branches     2097     9113     +7016     
===========================================
+ Hits         6980    11300     +4320     
- Misses       2327    12437    +10110     
- Partials      118     1759     +1641     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sanjayprabhu sanjayprabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changeset

@aditiharini aditiharini force-pushed the add-instrumentation-for-stream-reader branch from 06eb978 to af649f3 Compare September 10, 2024 22:04
@aditiharini aditiharini merged commit 4e897e9 into farcasterxyz:main Sep 11, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-chore Miscellaneous improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants