-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add createDefaultMetadataKeyInterceptor #2368
feat: add createDefaultMetadataKeyInterceptor #2368
Conversation
🦋 Changeset detectedLatest commit: 51790ca The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
70b82ee
to
f5397a8
Compare
Head branch was pushed to by a user without write access
I don't see how that test failure could be caused by my change. This function isn't even used. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2368 +/- ##
===========================================
- Coverage 74.05% 44.16% -29.90%
===========================================
Files 99 146 +47
Lines 9425 26203 +16778
Branches 2097 9272 +7175
===========================================
+ Hits 6980 11572 +4592
- Misses 2327 12815 +10488
- Partials 118 1816 +1698 ☔ View full report in Codecov by Sentry. |
Why is this change needed?
Neynar requires x-api-key to access its hubs. This change makes it easy to include that (or any other) header.
I tried to follow the docs to create a changes, but got an error. Am I running it from the wrong directory maybe?
Merge Checklist
Choose all relevant options below by adding an
x
now or at any time before submitting for reviewPR-Codex overview
This PR introduces a new function to create a metadata key interceptor for gRPC calls in the
hub-nodejs
package.Detailed summary
createDefaultMetadataKeyInterceptor
function inpackages/hub-nodejs/src/client.ts
.key
andvalue
, returning an interceptor that sets the specified metadata key with the given value if it is not already present.