Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: variable names and event handling logic #2421

Closed
wants to merge 10 commits into from

Conversation

intls
Copy link
Contributor

@intls intls commented Dec 9, 2024

Why is this change needed?

Describe why this issue should be fixed and link to any relevant design docs, issues or other relevant items.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR focuses on correcting typos in function and variable names across multiple files, specifically related to "verifications" and "multi addresses". It also ensures consistent naming conventions throughout the codebase.

Detailed summary

  • Fixed typo: solanaVerficationsEnabled to solanaVerificationsEnabled.
  • Corrected getAllVerficationMessagesByFid to getAllVerificationMessagesByFid.
  • Changed processRustCommitedTransaction to processRustCommittedTransaction.
  • Updated ConnectToMutliAddr to ConnectToMultiAddr in various locations.
  • Ensured consistent naming in comments.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Dec 9, 2024

⚠️ No Changeset found

Latest commit: 5c09792

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 10:17pm

@intls
Copy link
Contributor Author

intls commented Dec 9, 2024

@sds Hey! Resolved conflicts and opened a new PR.

@sds
Copy link
Member

sds commented Dec 9, 2024

Looks like tests are failing.

@intls
Copy link
Contributor Author

intls commented Dec 10, 2024

Looks like tests are failing.

@sds How can I solve it?

@sds
Copy link
Member

sds commented Dec 10, 2024

Look at the packages/shuttle/src/shuttle.integration.test.ts change.

It appears that there are now two declarations of the same method (getAllVerificationMessagesByFid) in this file, based on the error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants