Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix openSUSE ID Check Update hubble-bootstrap.sh #2429

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

mdqst
Copy link

@mdqst mdqst commented Dec 10, 2024

Why is this change needed?

This update addresses an issue in the bootstrap script where the detection of openSUSE systems was not functioning correctly.

Problem:

The script checks /etc/os-release for ID=openSUSE, but the actual value is ID=opensuse (lowercase). This mismatch causes the script to fail in identifying openSUSE systems.

Solution:

  • Updated the condition to use grep -iq "ID=opensuse" to ensure the check is case-insensitive.
  • This change ensures compatibility with all openSUSE installations.

Before:

elif [[ -f /etc/os-release ]] && grep -q "ID=openSUSE" /etc/os-release; then

After:

elif [[ -f /etc/os-release ]] && grep -iq "ID=opensuse" /etc/os-release; then

Additional Notes:

  • Tested on multiple Linux distributions to confirm compatibility.
  • The fix ensures a smoother user experience for openSUSE users.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR modifies the detection of the openSUSE operating system in the scripts/hubble-bootstrap.sh script to ensure case-insensitive matching for the ID field in /etc/os-release.

Detailed summary

  • Changed the grep command from grep -q "ID=openSUSE" to grep -iq "ID=opensuse" for case-insensitive matching.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Dec 10, 2024

⚠️ No Changeset found

Latest commit: e0ab1dd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 6:23pm

@sds sds added the t-bug A fix for a bug with the current system label Dec 10, 2024
@sds sds merged commit 917d8eb into farcasterxyz:main Dec 10, 2024
7 checks passed
@sds
Copy link
Member

sds commented Dec 10, 2024

Thank you.

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (1880070) to head (e0ab1dd).
Report is 442 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #2429       +/-   ##
==========================================
- Coverage   74.05%       0   -74.06%     
==========================================
  Files          99       0       -99     
  Lines        9425       0     -9425     
  Branches     2097       0     -2097     
==========================================
- Hits         6980       0     -6980     
+ Misses       2327       0     -2327     
+ Partials      118       0      -118     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-bug A fix for a bug with the current system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants