Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update 5.fnameSyncIds.test.ts file #2434

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

vsu727
Copy link
Contributor

@vsu727 vsu727 commented Dec 12, 2024

Why is this change needed?

Describe why this issue should be fixed and link to any relevant design docs, issues or other relevant items.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR focuses on correcting a typo in the test description for the fnameSyncIds migration.

Detailed summary

  • Changed the test description from "should delete unpaddded fname syncIds" to "should delete unpadded fname syncIds" in the file apps/hubble/src/storage/db/migrations/5.fnameSyncIds.test.ts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 2:36am

Copy link

changeset-bot bot commented Dec 12, 2024

⚠️ No Changeset found

Latest commit: 8b80c92

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sds sds merged commit fdcff5e into farcasterxyz:main Dec 12, 2024
7 checks passed
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (1880070) to head (8b80c92).
Report is 449 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #2434       +/-   ##
==========================================
- Coverage   74.05%       0   -74.06%     
==========================================
  Files          99       0       -99     
  Lines        9425       0     -9425     
  Branches     2097       0     -2097     
==========================================
- Hits         6980       0     -6980     
+ Misses       2327       0     -2327     
+ Partials      118       0      -118     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sds sds added the t-docs Add or update documentation label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-docs Add or update documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants