You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces new functionality for pruning messages in the messaging system. It adds requests and responses for pruning messages, modifies existing methods to clear cached message counts, and updates various files to support these changes.
Detailed summary
Added PruneMessagesRequest and PruneMessagesResponse messages in protobufs/schemas/request_response.proto.
Implemented PruneMessages RPC in protobufs/schemas/rpc.proto.
Created clearCachedMessageCount and clearStorageCacheForFid methods in apps/hubble/src/storage/stores/storeEventHandler.ts and apps/hubble/src/storage/engine/index.ts.
Updated pruneMessages method in apps/hubble/src/cli.ts and apps/hubble/src/hubble.ts.
Added pruneMessages method in apps/hubble/src/rpc/adminServer.ts with logging.
Modified packages/hub-nodejs/src/generated/request_response.ts and packages/hub-web/src/generated/request_response.ts to include new message interfaces.
Updated packages/hub-nodejs/src/generated/rpc.ts to include new RPC methods.
Enhanced packages/shuttle/src/shuttle/migration.ts to integrate pruning functionality during message ingestion.
✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this change needed?
Describe why this issue should be fixed and link to any relevant design docs, issues or other relevant items.
Merge Checklist
Choose all relevant options below by adding an
xnow or at any time before submitting for reviewPR-Codex overview
This PR introduces new functionality for pruning messages in the messaging system. It adds requests and responses for pruning messages, modifies existing methods to clear cached message counts, and updates various files to support these changes.
Detailed summary
PruneMessagesRequestandPruneMessagesResponsemessages inprotobufs/schemas/request_response.proto.PruneMessagesRPC inprotobufs/schemas/rpc.proto.clearCachedMessageCountandclearStorageCacheForFidmethods inapps/hubble/src/storage/stores/storeEventHandler.tsandapps/hubble/src/storage/engine/index.ts.pruneMessagesmethod inapps/hubble/src/cli.tsandapps/hubble/src/hubble.ts.pruneMessagesmethod inapps/hubble/src/rpc/adminServer.tswith logging.packages/hub-nodejs/src/generated/request_response.tsandpackages/hub-web/src/generated/request_response.tsto include new message interfaces.packages/hub-nodejs/src/generated/rpc.tsto include new RPC methods.packages/shuttle/src/shuttle/migration.tsto integrate pruning functionality during message ingestion.