Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variables and registerDebugListeners method #2488

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Fix variables and registerDebugListeners method #2488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bd0af2
gossipNode.ts
intls Jan 22, 2025
77ccc7e
syncEngine.test.ts
intls Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/hubble/src/network/p2p/gossipNode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,7 @@ export class GossipNode extends TypedEmitter<NodeEvents> {
/** Connects to a peer GossipNode through at least one multiaddr */
async connect(peerNode: GossipNode): Promise<HubResult<void>> {
const multiaddrs = peerNode.multiaddrs();
if (!multiaddrs || multiaddr.length === 0) {
if (!multiaddrs || multiaddrs.length === 0) {
return err(new HubError("unavailable", { message: "no peer id" }));
}

Expand Down Expand Up @@ -615,7 +615,7 @@ export class GossipNode extends TypedEmitter<NodeEvents> {

registerDebugListeners() {
this._nodeEvents?.addListener("peer:discovery", (detail) => {
log.info({ identity: this.identity }, `Found peer: ${detail.multiaddrs} }`);
log.info({ identity: this.identity }, `Found peer: ${detail.multiaddrs}`);
});
this._nodeEvents?.addListener("connection:open", (detail: Connection) => {
log.info({ identity: this.identity }, `Connection established to: ${detail.remotePeer.toString()}`);
Expand Down
2 changes: 1 addition & 1 deletion apps/hubble/src/network/sync/syncEngine.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,7 +525,7 @@ describe("SyncEngine", () => {
expect((await syncEngine.getDbStats()).numFnames).toEqual(1);
});

test("adds sync ids to the trie when not present and egnine rejects as duplicate", async () => {
test("adds sync ids to the trie when not present and engine rejects as duplicate", async () => {
await engine.mergeOnChainEvent(custodyEvent);
await engine.mergeUserNameProof(userNameProof);

Expand Down
Loading