Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow uppercase x usernames #2491

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aditiharini
Copy link
Contributor

@aditiharini aditiharini commented Jan 23, 2025

Why is this change needed?

We currently disallow uppercase x usernames which are valid.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR focuses on updating the username validation regex to allow uppercase letters for Twitter usernames.

Detailed summary

  • Modified the TWITTER_REGEX from /^[a-z0-9_]{0,15}$/ to /^[a-zA-Z0-9_]{0,15}$/ to permit uppercase letters in usernames.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Jan 23, 2025

🦋 Changeset detected

Latest commit: 39e642d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@farcaster/core Patch
@farcaster/hub-nodejs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 0:35am

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.94%. Comparing base (1880070) to head (39e642d).
Report is 471 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (1880070) and HEAD (39e642d). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (1880070) HEAD (39e642d)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2491       +/-   ##
===========================================
- Coverage   74.05%   34.94%   -39.12%     
===========================================
  Files          99      146       +47     
  Lines        9425    26282    +16857     
  Branches     2097     9328     +7231     
===========================================
+ Hits         6980     9185     +2205     
- Misses       2327    14728    +12401     
- Partials      118     2369     +2251     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant