Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve primary casts fetching logic #2495

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DeVikingMark
Copy link

@DeVikingMark DeVikingMark commented Jan 25, 2025

  • Implement pagination to fetch primary casts until desired count is reached
  • Add cursor-based iteration through messages
  • Increase page size for more efficient fetching
  • Add proper handling of empty results and pagination end
  • Remove TODO comment as the improvement is implemented

PR-Codex overview

This PR refines the getPrimaryCastsByFid function to fetch a specified number of primary casts that are not replies, using pagination to ensure all relevant casts are retrieved.

Detailed summary

  • Updated getPrimaryCastsByFid to accept a desiredCount parameter.
  • Introduced a loop to fetch primary casts until the desired count is reached.
  • Changed pageSize to 20 for each fetch.
  • Added cursor handling for pagination.
  • Adjusted return to provide a sliced array of primary casts based on desiredCount.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Jan 25, 2025

⚠️ No Changeset found

Latest commit: 77f72e2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 25, 2025 3:35am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant