-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: examples and patch hub-web to use grpc-web default export #867
Conversation
🦋 Changeset detectedLatest commit: f8b9340 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #867 +/- ##
==========================================
- Coverage 72.55% 72.39% -0.16%
==========================================
Files 66 66
Lines 5592 5614 +22
Branches 1292 1299 +7
==========================================
+ Hits 4057 4064 +7
- Misses 1434 1446 +12
- Partials 101 104 +3 see 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview:
|
Motivation
hub-nodejs
chron-feed example used an out-of-date package versionChange Summary
hub-nodejs
used in chron-feed example and integrate mentions as well@improbable-eng/grpc-web
in hub-web to use the default exportMerge Checklist
Choose all relevant options below by adding an
x
now or at any time before submitting for reviewAdditional Context
If this is a relatively large or complex change, provide more details here that will help reviewers