Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: examples and patch hub-web to use grpc-web default export #867

Merged
merged 6 commits into from
Apr 14, 2023

Conversation

pfletcherhill
Copy link
Contributor

@pfletcherhill pfletcherhill commented Apr 12, 2023

Motivation

Change Summary

  • Upgrade hub-nodejs used in chron-feed example and integrate mentions as well
  • Patch uses of @improbable-eng/grpc-web in hub-web to use the default export

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

  • PR title adheres to the conventional commits standard
  • PR has a changeset
  • PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore)
  • PR does not require changes to the protocol

Additional Context

If this is a relatively large or complex change, provide more details here that will help reviewers

@changeset-bot
Copy link

changeset-bot bot commented Apr 12, 2023

🦋 Changeset detected

Latest commit: f8b9340

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@farcaster/hub-web Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.16 ⚠️

Comparison is base (39387aa) 72.55% compared to head (f8b9340) 72.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #867      +/-   ##
==========================================
- Coverage   72.55%   72.39%   -0.16%     
==========================================
  Files          66       66              
  Lines        5592     5614      +22     
  Branches     1292     1299       +7     
==========================================
+ Hits         4057     4064       +7     
- Misses       1434     1446      +12     
- Partials      101      104       +3     

see 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
@farcaster/hub-web@0.2.4 eval +0 pfletcherhill

@pfletcherhill pfletcherhill changed the title fix: examples fix: examples and patch hub-web to use grpc-web default export Apr 14, 2023
@pfletcherhill pfletcherhill added the t-bug A fix for a bug with the current system label Apr 14, 2023
@pfletcherhill pfletcherhill merged commit ee953ec into farcasterxyz:main Apr 14, 2023
@pfletcherhill pfletcherhill deleted the examples branch April 14, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-bug A fix for a bug with the current system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant