Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Switch to rocksdb fork with precompiled Linux ARM build #960

Merged
merged 1 commit into from
May 11, 2023

Conversation

sds
Copy link
Member

@sds sds commented May 11, 2023

Motivation

With more Macs running ARM via Apple Silicon, the very slow package installation was problematic. Fix by using our fork (https://github.com/farcasterxyz/rocksdb) which includes the prebuilt ARM binary to significantly reduce installation time on Linux ARM systems.

This is necessary until the upstream project merges this PR: Level/rocksdb#216

Change Summary

Switch from the rocksdb package to the @farcaster/rocksdb package.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR switches from using the rocksdb package to the @farcaster/rocksdb package.

Detailed summary

  • Switch from rocksdb to @farcaster/rocksdb NPM package
  • Update import statements to use @farcaster/rocksdb instead of rocksdb
  • Update package.json to include @farcaster/rocksdb as a dependency
  • Remove rocksdb from package.json
  • Update type definitions for @farcaster/rocksdb in apps/hubble/src/rocksdb.d.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

With more Macs running ARM via Apple Silicon, the significantly slow
package installation was problematic. Fix by using our fork which
includes the prebuilt binary to reduce install time.
@changeset-bot
Copy link

changeset-bot bot commented May 11, 2023

🦋 Changeset detected

Latest commit: be0c3b6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@farcaster/hubble Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sds sds added t-chore Miscellaneous improvements t-devex Simplify the developer experience labels May 11, 2023
@sds sds changed the title Switch to rocksdb fork with precompiled Linux ARM build chore: Switch to rocksdb fork with precompiled Linux ARM build May 11, 2023
@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎


🚨 Potential security issues found in this pull request. To accept the risk, merge this PR and you will not be notified again.

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore @farcaster/rocksdb@5.5.0
🫣 Native code

Contains native code which could be a vector to obscure malicious code, and generally decrease the likelihood of reproducible or reliable installs.

Ensure that native code bindings are expected. Consumers may consider pure JS and functionally similar alternatives to avoid the challenges and risks associated with native code bindings.

Package Location Source
@farcaster/rocksdb@5.5.0 (added) binding.gyp apps/hubble/package.json
Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ⚠️ 1 issue
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
@farcaster/rocksdb@5.5.0 None +0 sds

🚮 Removed packages: rocksdb@5.2.1

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.10 🎉

Comparison is base (2ca66b1) 74.00% compared to head (be0c3b6) 74.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #960      +/-   ##
==========================================
+ Coverage   74.00%   74.10%   +0.10%     
==========================================
  Files          68       68              
  Lines        5943     5943              
  Branches     1385     1385              
==========================================
+ Hits         4398     4404       +6     
+ Misses       1445     1441       -4     
+ Partials      100       98       -2     
Impacted Files Coverage Δ
apps/hubble/src/allowedPeers.mainnet.ts 100.00% <ø> (ø)
apps/hubble/src/storage/db/rocksdb.ts 90.90% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sds sds merged commit fe755fb into main May 11, 2023
@sds sds deleted the sds/rocksdb branch May 11, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-chore Miscellaneous improvements t-devex Simplify the developer experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant