This repository has been archived by the owner on Jan 23, 2024. It is now read-only.
Support new Pokemon Go version #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any update on when this will be merged? |
As a first quick patch, it only modifies how it reads the appraisal. It tries to find the position of the box containing the stat bars. If the color match, it compares the bars (or more precise one pixel row) every 200 ms. It stops after 5 tries or when there are no changes and then interprets that into an IV combination. The checkboxes are necessary to say that a certain value is not actually valid, for example before it has read the screen in or when the user is manually inputting the values.
|
I think it could be merged in this state now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a first quick patch, it only modifies how it reads the appraisal.
Makes a PR so this change can be discussed and reviewed