Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v2): optimize scripts code #1892

Merged
merged 5 commits into from
Nov 1, 2024

Conversation

ErKeLost
Copy link
Member

@ErKeLost ErKeLost commented Oct 28, 2024

This pr will redefine all farm definitions of types

type grouping

    1. @farm/cli cli type
      CLI types include global general instruction types, start types, build types, and preview types
    1. @farmfe/core defineConfig
      defineConfig type include
      1. Basic types: Basic types mainly provide edge functions for nodes, such as base, logger,
      2. Compilation types: It mainly contains all types that need to be passed to rust on the node side
    1. @farmfe/core jsplugin Reorganize js plugin types

Copy link

changeset-bot bot commented Oct 28, 2024

⚠️ No Changeset found

Latest commit: cede70a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "farm-docs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@ErKeLost ErKeLost changed the base branch from main to v2-dev October 28, 2024 07:07
@ErKeLost ErKeLost added the WIP Working in progress label Oct 28, 2024
@fu050409 fu050409 changed the title refacotr(v2): redefine v2 type definition refactor(v2): redefine v2 type definition Oct 31, 2024
@ErKeLost ErKeLost changed the title refactor(v2): redefine v2 type definition refactor(v2): optimize scripts code Nov 1, 2024
@ErKeLost ErKeLost merged commit f91c260 into farm-fe:v2-dev Nov 1, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Working in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant