Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change the behavior of html minify #2013

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Huodoo
Copy link

@Huodoo Huodoo commented Dec 20, 2024

Description:
disabled quotes & closed tag removal behavior in html minify

BREAKING CHANGE:

Related issue (if exists):

Copy link

changeset-bot bot commented Dec 20, 2024

🦋 Changeset detected

Latest commit: a00c246

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@farmfe/core Patch
@farmfe-examples/tailwind-next Patch
@farmfe/js-plugin-tailwindcss Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ErKeLost ErKeLost requested a review from wre232114 December 22, 2024 06:31
@wre232114
Copy link
Member

Thanks!

Copy link

codspeed-hq bot commented Dec 23, 2024

CodSpeed Performance Report

Merging #2013 will create unknown performance changes

Comparing Huodoo:feat/changeHtmlMinifyBehavior (a00c246) with main (a785d6f)

Summary

⚠️ No benchmarks were detected in both the base of the PR and the PR.\

@shulandmimi
Copy link
Member

Thanks for the PR, but there are still some things to do

  1. Execute npx changeset in the project root directory and select @farmfe/core to generate a changeset file, we upgrade the version number according to this file (and this change is considered to be a patch
  2. Because the html generation has changed, the test snapshot needs to be updated. You can do this locally by running pnpm run test -- --update and FARM_UPDATE_SNAPSHOTS=1 cargo test.

@Huodoo Huodoo force-pushed the feat/changeHtmlMinifyBehavior branch 3 times, most recently from 7c9713e to 8b23bb3 Compare December 24, 2024 04:00
@Huodoo
Copy link
Author

Huodoo commented Dec 24, 2024

Thanks for the PR, but there are still some things to do

  1. Execute npx changeset in the project root directory and select @farmfe/core to generate a changeset file, we upgrade the version number according to this file (and this change is considered to be a patch
  2. Because the html generation has changed, the test snapshot needs to be updated. You can do this locally by running pnpm run test -- --update and FARM_UPDATE_SNAPSHOTS=1 cargo test.

Done

@Huodoo
Copy link
Author

Huodoo commented Dec 24, 2024

error but something wong with pnpm test -- -u ;also in master branch

@Huodoo Huodoo force-pushed the feat/changeHtmlMinifyBehavior branch from 8b23bb3 to bbd3e52 Compare December 24, 2024 05:51
@wre232114 wre232114 enabled auto-merge (squash) December 24, 2024 06:23
@ErKeLost
Copy link
Member

ErKeLost commented Jan 8, 2025

It seems that there is a problem with the ci of solid ssr example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants