add OakTrackedFeaturePacket and OakTrackedFeaturePackets
#175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarriba
changed the title
OakTrackedFeaturePacket and OakTrackedFeaturePackets
Hackerman342
approved these changes
Jan 24, 2024
| @@ -67,6 +67,25 @@ message OakImuPackets { | |||
| repeated OakImuPacket packets = 1; | |||
| } | |||
|
|
|||
| // Message for a single tracked feature | |||
| message OakTrackedFeaturePacket { | |||
| farm_ng.core.proto.Vec2F32 xy = 1; | |||
There was a problem hiding this comment.
Some description of the fields would be helpful
| message OakTrackedFeaturePacket { | ||
| farm_ng.core.proto.Vec2F32 xy = 1; | ||
| int32 id = 2; | ||
| int32 age = 3; |
There was a problem hiding this comment.
age as an int, not float? Just double checking this was the intent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.