Fix ServiceState constructors for 0 Enum #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanrublee
approved these changes
Nov 22, 2022
edgarriba
reviewed
Nov 23, 2022
| @@ -28,7 +28,9 @@ class CanbusServiceState: | |||
| """Canbus service state.""" | |||
|
|
|||
| def __init__(self, proto: canbus_pb2.CanbusServiceState = None) -> None: | |||
| self._proto = proto or canbus_pb2.CanbusServiceState.UNAVAILABLE | |||
| self._proto = canbus_pb2.CanbusServiceState.UNAVAILABLE | |||
There was a problem hiding this comment.
self._proto = proto or canbus_pb2.CanbusServiceState.UNAVAILABLE
There was a problem hiding this comment.
@edgarriba That was causing a bug. If the proto is the 0 item in the FooServiceState Enum, it evaluates to False and is set to UNAVAILABLE instead of the passed proto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.