Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protobuf plumbing. #9

Merged
merged 10 commits into from
Oct 25, 2022
Merged

protobuf plumbing. #9

merged 10 commits into from
Oct 25, 2022

Conversation

ethanrublee
Copy link
Member

No description provided.

edgarriba
edgarriba reviewed Oct 24, 2022
View reviewed changes
Copy link
Member

@edgarriba edgarriba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bit orthogonal to the proto definition but i was reading that is a recommended practice to always add for enums UNKNOWN=0

@edgarriba
Copy link
Member

edgarriba commented Oct 24, 2022 •
edited
Loading

@ethanrublee for some reason i noticed that pip install -e . do not produce the controller_pb2 module, while with python setup.py develop no issues

@ethanrublee
Copy link
Member Author

Huh, this is probably to do with some other fixes I'm working on where include paths get added for sophus and farm-ng-core during proto build. Will try to reproduce

@ethanrublee ethanrublee merged commit 58b4e1a into main Oct 25, 2022
@ethanrublee ethanrublee deleted the protobuf-install branch October 25, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgarriba edgarriba edgarriba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanrublee @edgarriba