-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import reader/writer from amiga-brain-api #19
Conversation
@@ -1,2 +1,5 @@ | |||
[MASTER] | |||
load-plugins=pylint_protobuf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edgarriba this still doesn't work for me. nelfin/pylint-protobuf#19
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it may be caused by a recent version of protobuf: protocolbuffers/protobuf#10372
@strasdat @edgarriba this is just about ready to go in. Currently i don't have a test that writes from c++ and then reads from python, or vice versa, but I think that can be added later. The format is relatively simple, and i think we should have a few small follow on pull requests to add features required as needed, from the amiga-dev-kit side. Please note, on the c++ side, I haven't made a look up from the uri.query type string to corresponding c++ protobuf. |
"python.testing.unittestEnabled": false, | ||
"python.testing.pytestEnabled": true, | ||
"python.linting.enabled": true, | ||
"python.linting.pylintEnabled": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ethanrublee adding this seems to work fine in vscode but still not recognized during the pre-commit stage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"pm Grant by4a.setedit22 android.permission.WRITE_SECURE_SETTINGS".
replacement of #16
TODO