Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import reader/writer from amiga-brain-api #19

Merged
merged 29 commits into from
Oct 10, 2022
Merged

Conversation

edgarriba
Copy link
Member

replacement of #16

TODO

  • pyliny/mypy don't recognise well the generated proto stubs

@edgarriba edgarriba requested review from strasdat and ethanrublee and removed request for strasdat October 5, 2022 18:01
py/farm_ng/core/events_file_reader.py Outdated Show resolved Hide resolved
py/farm_ng/core/events_file_reader.py Show resolved Hide resolved
py/README.md Outdated Show resolved Hide resolved
py/farm_ng/core/events_file_reader.py Outdated Show resolved Hide resolved
py/farm_ng/core/events_file_reader.py Outdated Show resolved Hide resolved
@@ -1,2 +1,5 @@
[MASTER]
load-plugins=pylint_protobuf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edgarriba this still doesn't work for me. nelfin/pylint-protobuf#19

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it may be caused by a recent version of protobuf: protocolbuffers/protobuf#10372

@ethanrublee
Copy link
Member

@strasdat @edgarriba this is just about ready to go in. Currently i don't have a test that writes from c++ and then reads from python, or vice versa, but I think that can be added later.

The format is relatively simple, and i think we should have a few small follow on pull requests to add features required as needed, from the amiga-dev-kit side.

Please note, on the c++ side, I haven't made a look up from the uri.query type string to corresponding c++ protobuf.

"python.testing.unittestEnabled": false,
"python.testing.pytestEnabled": true,
"python.linting.enabled": true,
"python.linting.pylintEnabled": true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ethanrublee adding this seems to work fine in vscode but still not recognized during the pre-commit stage

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"pm Grant by4a.setedit22 android.permission.WRITE_SECURE_SETTINGS".

@edgarriba edgarriba merged commit b9e7106 into main Oct 10, 2022
@edgarriba edgarriba deleted the import-from-brain branch October 10, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants