Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jenkins source #64

Merged
merged 67 commits into from
Sep 25, 2021
Merged

Add Jenkins source #64

merged 67 commits into from
Sep 25, 2021

Conversation

Roma-Kyrnis
Copy link
Contributor

@Roma-Kyrnis Roma-Kyrnis commented Sep 3, 2021

Description

Provide description here

Type of change

  • Bug fix
  • New feature
  • Breaking change

Related issues

#19

Copy link
Contributor

@cjwooo cjwooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comments

sources/jenkins-source/src/stream.ts Outdated Show resolved Hide resolved
sources/jenkins-source/src/stream.ts Outdated Show resolved Hide resolved
sources/jenkins-source/src/stream.ts Show resolved Hide resolved
@tovbinm tovbinm changed the title add jenkins-source Add Jenkins source Sep 22, 2021
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@tovbinm tovbinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! some minor comments

.github/workflows/ci.yml Outdated Show resolved Hide resolved
- name: Source Acceptance Test
if: github.ref == 'refs/heads/main' # Skip PRs
# if: github.ref == 'refs/heads/main' # Skip PRs
Copy link
Contributor

@tovbinm tovbinm Sep 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comment #

@tovbinm tovbinm merged commit 9a78a69 into main Sep 25, 2021
@tovbinm tovbinm deleted the rk/add-jenkins-source branch September 25, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants