Minor fixes in mission module

[christophe-david]

This PR addresses 2 small problems:

• lift value was generally not computed (knowing CL can be enough), though the column is always in csv files.
• in ClimbAndCruise segment, the target of inner climb segment could be set without guarantee the climb segment was not None.

Additionally, some refactoring has been done to have CL and CD computed in only one location. For this purpose, abstract classes AbstractLiftFromWeightSegment and AbstractLiftFromAoASegment have been created, in the same purpose as AbstractManualThrustSegment and AbstractRegulatedThrustSegment.

BTW, the load_factor attribute has been added to AbstractLiftFromWeightSegment. It's an easy addition that allows to simulate segments with load factors different from 1.

[codecov]

Codecov Report

Attention: Patch coverage is 97.87234% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.92%. Comparing base (0eb2816) to head (90d6bef).
Report is 10 commits behind head on master.

Files with missing lines	Patch %	Lines
...performances/mission/segments/registered/cruise.py	75.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #579      +/-   ##
==========================================
+ Coverage   91.91%   91.92%   +0.01%     
==========================================
  Files         100      100              
  Lines        6183     6169      -14     
  Branches      973      974       +1     
==========================================
- Hits         5683     5671      -12     
+ Misses        334      333       -1     
+ Partials      166      165       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[esnguyenvan]

Thanks for the clean-up. Seems all good to me.

[christophe-david]

Thanks for the clean-up. Seems all good to me.

Sorry, just realized lift_equals_weight should have been a class attribute, not an instance one. And BTW, I consider now inheritance looks a better option to handle that. Stay tuned...

[esnguyenvan]

Seems good to me thanks for cleaning this up, it will solve additional issues. I would suggest to complete the documentation of the hold segment with the new load factor feature.

[esnguyenvan]

Thanks for deleting this unnecessary overload, it fixed the values in brackets in the flight point at the same time. It took me while to figure it out: this overload does not apply the scalarise() method at the end.