Issue #30 with bugfixes #40
Merged
+104
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have added a commandline option "-shell" which you can specify a different location for bash rather than /bin/bash. Initial testing looks good. |
|
Good job! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the patch in issue #30
I created a pull request with the original authors changes, but I found some problematic changes so I deleted the pull request.
I have put together what I believe is the best of the patch into my repo.
I also fixed a build warning relating to a dependancy library as well as a bugfix related to log file writing.
I am currently testing this on AIX 7.1, RHEL7, Windows Server, and even with a small modification to the location of bash on an IBM mainframe. Thank you again for sharing this software.