Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bitwise or instead of conditional mov #29

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/avx512bitpacking.c
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@ static uint32_t maxbitas32int(const __m256i accumulator) {
const __m256i _tmp2 = _mm256_or_si256(_mm256_srli_si256(_tmp1, 4), _tmp1);
uint32_t ans1 = _mm256_extract_epi32(_tmp2, 0);
uint32_t ans2 = _mm256_extract_epi32(_tmp2, 4);
uint32_t ans = ans1 > ans2 ? ans1 : ans2;
uint32_t ans = ans1 | ans2;
return ans;
}

static uint32_t avx512maxbitas32int(const __m512i accumulator) {
uint32_t ans1 = maxbitas32int(_mm512_castsi512_si256(accumulator));
uint32_t ans2 = maxbitas32int(_mm512_extracti64x4_epi64(accumulator, 1));
uint32_t ans = ans1 > ans2 ? ans1 : ans2;
uint32_t ans = ans1 | ans2;
return bits(ans);
}

Expand Down
2 changes: 1 addition & 1 deletion src/avxbitpacking.c
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ static uint32_t maxbitas32int(const __m256i accumulator) {
const __m256i _tmp2 = _mm256_or_si256(_mm256_srli_si256(_tmp1, 4), _tmp1);
uint32_t ans1 = _mm256_extract_epi32(_tmp2, 0);
uint32_t ans2 = _mm256_extract_epi32(_tmp2, 4);
uint32_t ans = ans1 > ans2 ? ans1 : ans2;
uint32_t ans = ans1 | ans2;
return bits(ans);
}

Expand Down