refactor: libfastrace C++ interface for improved safety and usability #4
+676
−285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace C-style function calls with type-safe C++ wrappers - Implement move semantics for Span and LocalSpan classes - Use call_rust_function template for safer Rust-C++ interop - Replace unions with reinterpret_cast for cleaner type conversions - Add vector-based property handling for more flexible API - Update examples to use new C++ interface - Improve memory management with RAII principles - Enhance code readability and maintainability Signed-off-by: Wenbo Zhang <wenbo.zhang@iomesh.com>
ethercflow
changed the title
tisonkun
approved these changes
Oct 19, 2024
andylokandy
approved these changes
Oct 19, 2024
andylokandy
reviewed
Oct 19, 2024
| : span_(new ftr_span(ftr_create_child_span_enter_loc(name))) {} | ||
|
|
||
| Span::~Span() { | ||
| if (span_) { |
There was a problem hiding this comment.
@andylokandy To support move constructor
Signed-off-by: Wenbo Zhang <wenbo.zhang@iomesh.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3