👷 Add Lint to GitHub Actions outside of tests (#688)

fastapi · Mar 12, 2024 · 691443c · 691443c
1 parent 87099ec
commit 691443c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -25,7 +25,9 @@ jobs:
       - run: docker compose build
       - run: docker compose down -v --remove-orphans
       - run: docker compose up -d
-      - name: Docker Compose run tests
+      - name: Lint
+        run: docker compose exec -T backend bash /app/scripts/lint.sh
+      - name: Run tests
         run: docker compose exec -T backend bash /app/tests-start.sh "Coverage for ${{ github.sha }}"
       - run: docker compose down -v --remove-orphans
       - name: Store coverage files

diff --git a/backend/backend.dockerfile b/backend/backend.dockerfile
@@ -17,6 +17,8 @@ RUN bash -c "if [ $INSTALL_DEV == 'true' ] ; then poetry install --no-root ; els
 
 ENV PYTHONPATH=/app
 
+COPY ./scripts/ /app/
+
 COPY ./alembic.ini /app/
 
 COPY ./prestart.sh /app/

diff --git a/backend/tests-start.sh b/backend/tests-start.sh
@@ -4,5 +4,4 @@ set -x
 
 python /app/app/tests_pre_start.py
 
-bash ./scripts/lint.sh
 bash ./scripts/test.sh "$@"
Original file line number	Diff line number	Diff line change
Expand Up		@@ -4,5 +4,4 @@ set -x

		python /app/app/tests_pre_start.py

		bash ./scripts/lint.sh
		bash ./scripts/test.sh "$@"