-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cookiecutter Windows Bug in worker-start.sh: CRLF Linebreaks #13
Comments
Thanks! I think it's a problem in Cookiecutter itself, this PR seems to fix it: cookiecutter/cookiecutter#1159 |
This should be fixed by #149 🎉 |
alejsdev
added a commit
that referenced
this issue
Dec 19, 2024
Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Esteban Maya <emayacadavid9@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
First, many thanks for this project! I am lookin forward to testing it.
I had some problems getting it to run on Windows and found the source (it was me). Even though it was my fault, I thought a note in the readme could be added for other users:
The backend would not start because linebreaks in
worker-start.sh
(and other bash-files) were CRLF (Windows), and not LF (Linux). Indocker-compose logs
this would appear asinvalid command \r
etc.I used cookiecutter in Windows with
cookiecutter https://github.com/tiangolo/full-stack-fastapi-postgresql
, which issued CRLF linebreaks. Once using cookiecutter from WSL bash in Ubuntu, everything worked fine!I think it generally a good recommendation to use docker-compose, and docker from WSL bash (connected through Windows Docker daemon running on localhost); and set VSCode (if used from Windows), to use LF in global settings with
"files.eol": "\n"
.The text was updated successfully, but these errors were encountered: